cores: arduino: zephyrCommon Specify port/pin instead of `gpio_dt_spec` #148

soburi · 2026-01-31T13:52:51Z

In preparation for improvements to allow the use of GPIOs without
device tree definitions,
the interface will be changed to specify port and pin instead of
gpio_dt_spec.

Copilot

Pull request overview

Updates the Arduino-on-Zephyr core to prefer direct GPIO port/pin usage over gpio_dt_spec, and adjusts build logic to better select board-/revision-specific devicetree overlays and variant directories.

Changes:

Refactor GPIO access in zephyrCommon.cpp to use helpers that expose GPIO port + pin for common operations (digital I/O, tone, pulseIn, interrupts).
Update sample CMakeLists.txt files to prefer a ${NORMALIZED_BOARD_TARGET}_${BOARD_REVISION}.overlay when present, falling back to ${NORMALIZED_BOARD_TARGET}.overlay.
Adjust top-level variant directory selection to look for variants/${BOARD} or variants/${NORMALIZED_BOARD_TARGET}.

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
CMakeLists.txt	Updates variant directory discovery to support additional naming patterns.
cores/arduino/zephyrCommon.cpp	Refactors GPIO operations to use port/pin helpers instead of `_dt` convenience APIs in multiple call sites.
samples/analog_input/CMakeLists.txt	Adds overlay selection logic with optional board revision overlay.
samples/attach_interrupt/CMakeLists.txt	Adds overlay selection logic with optional board revision overlay.
samples/blinky_arduino/CMakeLists.txt	Adds overlay selection logic with optional board revision overlay.
samples/button_press_led/CMakeLists.txt	Adds overlay selection logic with optional board revision overlay.
samples/fade/CMakeLists.txt	Adds overlay selection logic with optional board revision overlay.
samples/hello_arduino/CMakeLists.txt	Adds overlay selection logic with optional board revision overlay.
samples/i2cdemo/CMakeLists.txt	Adds overlay selection logic with optional board revision overlay.
samples/serial_event/CMakeLists.txt	Adds overlay selection logic with optional board revision overlay.
samples/spi_controller/CMakeLists.txt	Adds overlay selection logic with optional board revision overlay.
samples/threads_arduino/CMakeLists.txt	Adds overlay selection logic with optional board revision overlay.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

cores/arduino/zephyrCommon.cpp

CMakeLists.txt

cores/arduino/zephyrCommon.cpp

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

cores/arduino/zephyrCommon.cpp

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

cores/arduino/zephyrCommon.cpp

In preparation for improvements to allow the use of GPIOs without device tree definitions, the interface will be changed to specify port and pin instead of `gpio_dt_spec`. Signed-off-by: TOKITA Hiroshi <tokita.hiroshi@gmail.com>

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 9 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-05T14:23:48Z

cores/arduino/zephyrCommon.cpp

+constexpr inline const struct device *local_gpio_port(pin_size_t gpin) {
+	return arduino_pins[gpin].port;
+}
+
+constexpr inline pin_size_t local_gpio_pin(pin_size_t gpin) {
+	return arduino_pins[gpin].pin;
+}
+


The helper functions local_gpio_port() and local_gpio_pin() only extract the port and pin from gpio_dt_spec, discarding the dt_flags field. This means GPIO_ACTIVE_LOW flags defined in devicetree (e.g., variants/nrf52840dk_nrf52840/nrf52840dk_nrf52840.overlay:25) are no longer respected by functions that use these helpers. To maintain backward compatibility and support active-low GPIOs, either continue using the *_dt API variants (gpio_pin_set_dt, gpio_pin_get_dt, gpio_pin_toggle_dt), or create additional helpers that apply dt_flags inversion when needed.

Suggested change

constexpr inline const struct device *local_gpio_port(pin_size_t gpin) {

return arduino_pins[gpin].port;

}

constexpr inline pin_size_t local_gpio_pin(pin_size_t gpin) {

return arduino_pins[gpin].pin;

}

constexpr inline const struct gpio_dt_spec &local_gpio_dt_spec(pin_size_t gpin) {

return arduino_pins[gpin];

}

inline int local_gpio_pin_set(pin_size_t gpin, int value) {

return gpio_pin_set_dt(&arduino_pins[gpin], value);

}

inline int local_gpio_pin_get(pin_size_t gpin) {

return gpio_pin_get_dt(&arduino_pins[gpin]);

}

inline int local_gpio_pin_toggle(pin_size_t gpin) {

return gpio_pin_toggle_dt(&arduino_pins[gpin]);

}

Copilot · 2026-02-05T14:23:49Z

cores/arduino/zephyrCommon.cpp

+    gpio_pin_set(local_gpio_port(pt->pin), local_gpio_pin(pt->pin), 0);
  } else {
-    gpio_pin_toggle_dt(spec);
+    gpio_pin_toggle(local_gpio_port(pt->pin), local_gpio_pin(pt->pin));


Switching from gpio_pin_toggle_dt() to gpio_pin_toggle() loses GPIO_ACTIVE_LOW flag handling. For active-low pins, the toggle behavior may be inverted. Either use gpio_pin_toggle_dt() or manually account for dt_flags.

Suggested change

gpio_pin_toggle(local_gpio_port(pt->pin), local_gpio_pin(pt->pin));

gpio_pin_toggle_dt(&arduino_pins[pt->pin]);

Copilot · 2026-02-05T14:23:49Z

cores/arduino/zephyrCommon.cpp

  k_timer_init(timer, tone_expiry_cb, NULL);

-  gpio_pin_set_dt(spec, 0);
+  gpio_pin_set(local_gpio_port(pinNumber), local_gpio_pin(pinNumber), 0);


Switching from gpio_pin_set_dt() to gpio_pin_set() loses GPIO_ACTIVE_LOW flag handling. For active-low pins, the timer start reset behavior will be incorrect. Either use gpio_pin_set_dt() or manually account for dt_flags inversion.

Copilot · 2026-02-05T14:23:49Z

cores/arduino/zephyrCommon.cpp

-
  k_timer_stop(&arduino_pin_timers[pinNumber].timer);
-  gpio_pin_set_dt(spec, 0);
+  gpio_pin_set(local_gpio_port(pinNumber), local_gpio_pin(pinNumber), 0);


Switching from gpio_pin_set_dt() to gpio_pin_set() loses GPIO_ACTIVE_LOW flag handling. For active-low pins, the noTone reset behavior will be incorrect. Either use gpio_pin_set_dt() or manually account for dt_flags inversion.

Copilot · 2026-02-05T14:23:50Z

cores/arduino/zephyrCommon.cpp

+  while(gpio_pin_get(port, pin) == state && k_timer_status_get(&timer) == 0);
  if (k_timer_status_get(&timer) > 0) {
    goto cleanup;
  }

-  while(gpio_pin_get_dt(spec) != state && k_timer_status_get(&timer) == 0);
+  while(gpio_pin_get(port, pin) != state && k_timer_status_get(&timer) == 0);
  if (k_timer_status_get(&timer) > 0) {
    goto cleanup;
  }

  start = k_uptime_ticks();
-  while(gpio_pin_get_dt(spec) == state && k_timer_status_get(&timer) == 0);
+  while(gpio_pin_get(port, pin) == state && k_timer_status_get(&timer) == 0);


Switching from device_is_ready(spec->port) via gpio_is_ready_dt() to device_is_ready(port) is correct for checking port readiness. However, the subsequent gpio_pin_get() calls on lines 462, 467, and 473 lose GPIO_ACTIVE_LOW flag handling. For active-low pins, the state comparisons will be inverted. Either use gpio_pin_get_dt() or manually invert based on dt_flags.

Copilot · 2026-02-05T14:23:50Z

cores/arduino/zephyrCommon.cpp


 void digitalWrite(pin_size_t pinNumber, PinStatus status) {
-  gpio_pin_set_dt(&arduino_pins[pinNumber], status);
+  gpio_pin_set(local_gpio_port(pinNumber), local_gpio_pin(pinNumber), status);


Switching from gpio_pin_set_dt() to gpio_pin_set() loses the GPIO_ACTIVE_LOW flag handling. For pins configured with GPIO_ACTIVE_LOW in devicetree (present in nrf52840dk_nrf52840.overlay and nrf9160dk_nrf9160.overlay), digitalWrite(pin, HIGH) will now drive the physical line high instead of low, inverting the intended behavior. Either use gpio_pin_set_dt() to preserve dt_flags handling, or manually invert the status parameter based on arduino_pins[pinNumber].dt_flags.

Suggested change

gpio_pin_set(local_gpio_port(pinNumber), local_gpio_pin(pinNumber), status);

gpio_pin_set_dt(&arduino_pins[pinNumber], status);

Copilot · 2026-02-05T14:23:50Z

cores/arduino/zephyrCommon.cpp

  if (pt->count == 0) {
    k_timer_stop(timer);
-    gpio_pin_set_dt(spec, 0);
+    gpio_pin_set(local_gpio_port(pt->pin), local_gpio_pin(pt->pin), 0);


Switching from gpio_pin_set_dt() to gpio_pin_set() in the tone stop path loses GPIO_ACTIVE_LOW flag handling. For active-low pins, setting value 0 may actually assert the pin instead of de-asserting it. Either use gpio_pin_set_dt() or manually account for dt_flags inversion.

Copilot · 2026-02-05T14:23:50Z

cores/arduino/zephyrCommon.cpp


  if (frequency == 0) {
-    gpio_pin_set_dt(spec, 0);
+    gpio_pin_set(local_gpio_port(pinNumber), local_gpio_pin(pinNumber), 0);


Switching from gpio_pin_set_dt() to gpio_pin_set() loses GPIO_ACTIVE_LOW flag handling. For active-low pins, the initial reset behavior will be incorrect. Either use gpio_pin_set_dt() or manually account for dt_flags inversion.

cores/arduino/zephyrCommon.cpp

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

soburi changed the title ~~No use gpio dt spec~~ cores: arduino: zephyrCommon Specify port/pin instead of gpio_dt_spec. Jan 31, 2026

soburi changed the title ~~cores: arduino: zephyrCommon Specify port/pin instead of gpio_dt_spec.~~ cores: arduino: zephyrCommon Specify port/pin instead of gpio_dt_spec. Jan 31, 2026

soburi changed the title ~~cores: arduino: zephyrCommon Specify port/pin instead of gpio_dt_spec.~~ cores: arduino: zephyrCommon Specify port/pin instead of gpio_dt_spec Jan 31, 2026

soburi added the DNM This PR should not be merged (Do Not Merge) label Feb 1, 2026

soburi marked this pull request as ready for review February 1, 2026 13:48

soburi requested a review from DhruvaG2000 as a code owner February 1, 2026 13:48

Copilot AI review requested due to automatic review settings February 1, 2026 13:48

soburi requested review from beriberikix and szczys as code owners February 1, 2026 13:48

Copilot started reviewing on behalf of soburi February 1, 2026 13:49 View session

Copilot AI reviewed Feb 1, 2026

View reviewed changes

cores/arduino/zephyrCommon.cpp Show resolved Hide resolved

CMakeLists.txt Show resolved Hide resolved

cores/arduino/zephyrCommon.cpp Show resolved Hide resolved

soburi marked this pull request as draft February 1, 2026 14:24

soburi force-pushed the no_use_gpio_dt_spec branch from 2c89225 to 1567002 Compare February 3, 2026 10:58

soburi requested a review from Copilot February 3, 2026 11:35

Copilot started reviewing on behalf of soburi February 3, 2026 11:35 View session

Copilot AI reviewed Feb 3, 2026

View reviewed changes

cores/arduino/zephyrCommon.cpp Show resolved Hide resolved

cores/arduino/zephyrCommon.cpp Show resolved Hide resolved

cores/arduino/zephyrCommon.cpp Show resolved Hide resolved

cores/arduino/zephyrCommon.cpp Show resolved Hide resolved

soburi requested a review from Copilot February 3, 2026 11:49

Copilot started reviewing on behalf of soburi February 3, 2026 11:49 View session

Copilot AI reviewed Feb 3, 2026

View reviewed changes

cores/arduino/zephyrCommon.cpp Show resolved Hide resolved

cores/arduino/zephyrCommon.cpp Show resolved Hide resolved

cores/arduino/zephyrCommon.cpp Outdated Show resolved Hide resolved

soburi force-pushed the no_use_gpio_dt_spec branch from 1567002 to 6e983d1 Compare February 3, 2026 21:28

soburi force-pushed the no_use_gpio_dt_spec branch from 6e983d1 to 46287d2 Compare February 5, 2026 10:58

soburi requested a review from Copilot February 5, 2026 14:18

Copilot started reviewing on behalf of soburi February 5, 2026 14:19 View session

Copilot AI reviewed Feb 5, 2026

View reviewed changes

Update cores/arduino/zephyrCommon.cpp

d6d705d

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

-constexpr inline const struct device *local_gpio_port(pin_size_t gpin) {
-	return arduino_pins[gpin].port;
-}
-constexpr inline pin_size_t local_gpio_pin(pin_size_t gpin) {
-	return arduino_pins[gpin].pin;
-}
+constexpr inline const struct gpio_dt_spec &local_gpio_dt_spec(pin_size_t gpin) {
+	return arduino_pins[gpin];
+}
+inline int local_gpio_pin_set(pin_size_t gpin, int value) {
+	return gpio_pin_set_dt(&arduino_pins[gpin], value);
+}
+inline int local_gpio_pin_get(pin_size_t gpin) {
+	return gpio_pin_get_dt(&arduino_pins[gpin]);
+}
+inline int local_gpio_pin_toggle(pin_size_t gpin) {
+	return gpio_pin_toggle_dt(&arduino_pins[gpin]);
+}

	gpio_pin_toggle(local_gpio_port(pt->pin), local_gpio_pin(pt->pin));
	gpio_pin_toggle_dt(&arduino_pins[pt->pin]);

	gpio_pin_set(local_gpio_port(pinNumber), local_gpio_pin(pinNumber), status);
	gpio_pin_set_dt(&arduino_pins[pinNumber], status);

cores: arduino: zephyrCommon Specify port/pin instead of gpio_dt_spec #148

Are you sure you want to change the base?

cores: arduino: zephyrCommon Specify port/pin instead of gpio_dt_spec #148

Conversation

soburi commented Jan 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

cores: arduino: zephyrCommon Specify port/pin instead of `gpio_dt_spec` #148

cores: arduino: zephyrCommon Specify port/pin instead of `gpio_dt_spec` #148

soburi commented Jan 31, 2026 •

edited

Loading